Re: [PATCH 5/5] run_hook(): allow more than 9 hook arguments

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 16, 2009, 21:05 UTC
Message-ID: <alpine.DEB.1.00.0901162203260.3586@pacific.mpi-cbg.de>
In-Reply-To: <1232133002-21725-5-git-send-email-s-beyer@gmx.net>

Hi,

On Fri, 16 Jan 2009, Stephan Beyer wrote:

Show 16 quoted lines

> This is accomplished using the ALLOC_GROW macro.
> 
> 5 cells are initially allocated for the argv array, allowing
> four actual arguments without reallocating memory.
> 
> Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
> ---
> 
> 	I was a little unsure if it looks better to
> 	initialize i = 0, alloc = 0
> 	and do:
> 		ALLOC_GROW(argv, i + 1, alloc);
> 		argv[i++] = git_path("hooks/%s", name);
> 	instead of the xmalloc().
> 
> 	Do some people care about details like that?

	Actually, you need to do it before setting argv[0], and I think it 
	would look better to let ALLOC_GROW() handle the allocation: less 
	opportunity for bugs to lurk.

	Besides that, ALLOC_GROW() will allocate 16 entries initially, 
	plenty enough for anyone, I guess.

Ciao, Dscho