Re: [PATCH] Get format-patch to show first commit after root commit

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 10, 2009, 10:27 UTC
Message-ID: <alpine.DEB.1.00.0901101122570.30769@pacific.mpi-cbg.de>
In-Reply-To: <49679f61.1b068e0a.048f.70e4@mx.google.com>

Hi,

your mailing process has a problem; neither the recipients nor the subject made it into the mail header.

On Fri, 9 Jan 2009, nathan.panike@gmail.com wrote:

Show 8 quoted lines

> >From 65c4fed27fe9752ffd0e3b7cb6807561a4dd4601 Mon Sep 17 00: 00:00 2001
> From: Nathan W. Panike <nathan.panike@gmail.com>
> Date: Fri, 9 Jan 2009 11:53:43 -0600
> Subject: [PATCH] Get format-patch to show first commit after root commit
> 
> Currently, the command
> 
> git format-patch -1 e83c5163316f89bfbde

You do not need -1, and using 19 digits seems a bit arbitrary; the convention seems to be 7 digits (that is what --abbrev-commit does).

Show 11 quoted lines

> 
> in the git repository creates an empty file.  Instead, one is
> forced to do
> 
> git format-patch -1 --root e83c5163316f89bfbde
> 
> This seems arbitrary.  This patch fixes this case, so that
> 
> git format-patch -1 e83c5163316f89bfbde
> 
> will produce an actual patch.

IMHO mentioning --root is misleading, as the real bug is the empty diff.

Apart from that, I like the patch, though.

Thanks, Dscho