git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin-shortlog.c: use string_list_append() instead of duplicating its code

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 30, 2008, 12:20 UTC
Message-ID
<alpine.DEB.1.00.0812301319140.30769@pacific.mpi-cbg.de>
In-Reply-To
<1230136476-11081-1-git-send-email-dato@net.com.org.es>
Hi,
On Wed, 24 Dec 2008, Adeodato Simó wrote:
Show 8 quoted lines
> Also, when clearing the "onelines" string lists, do not free the "util"
> member: with string_list_append() is not initialized to any value (and
> was being initialized to NULL previously anyway).
> 
> NB: The duplicated code in builtin-shortlog.c predated the appearance of
> string_list_append().
> 
> Signed-off-by: Adeodato Simó <dato@net.com.org.es>

FWIW I like the patch, but would like it even more if the strdup() removal was squashed in (with an explanation in the commit message).

Ciao, Dscho

Previous: Adeodato SimóNext: Adeodato Simó
Message 2 of 4 in “builtin-shortlog.c: use string_list_append() instead of duplicating its code”
  1. builtin-shortlog.c: use string_list_append() instead of duplicating its codeAdeodato Simó, Dec 24, 2008
  2. Johannes SchindelinDec 30, 2008
  3. builtin-shortlog.c: use string_list_append(), and don't strdup unnecessarilyAdeodato Simó, Dec 30, 2008
  4. builtin-shortlog.c: use string_list_append(), and don't strdup unnecessarilyAdeodato Simó, Dec 30, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.