Re: What's cooking in git.git (Dec 2008, #03; Sun, 21)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 24, 2008, 11:55 UTC
Message-ID: <alpine.DEB.1.00.0812241252080.30769@pacific.mpi-cbg.de>
In-Reply-To: <20081223173438.GA25699@coredump.intra.peff.net>

Hi,

On Tue, 23 Dec 2008, Jeff King wrote:

Show 13 quoted lines

> On Tue, Dec 23, 2008 at 05:52:54PM +0100, Johannes Schindelin wrote:
> 
> > However, note that without something like core.notesref you will never 
> > be able to have private and public notes.
> > 
> > And I very much want to have private notes _and_ public notes on the 
> > very same commits of the very same branches.
> 
> Right. I think core.notesref doesn't go far enough, because it doesn't
> provide a way to talk about notes from two sources at the same time.
> Like:
> 
>   git log --pretty=format:'%N(my-private-notes:foo) %N(public-notes:bar)'

Ah. That should be easy to do incrementally, by adding a ref_name parameter to the functions in notes.h, which can be NULL (falling back to the default ref).

Show 7 quoted lines

> > And while I am almost sure that there is a stupid bug lurking that 
> > will kick the performance again, I think the basic design is sound, 
> > and it should be easy to modify no matter which way you want to change 
> > the behavior with regards to trees/blobs or refs.
> 
> I agree that the data structure is sound, so I can probably work on top
> of what you posted, too. I was planning on doing git-notes in C, though.

Sure. git-notes.sh is only in shell script to provide a proof-of-concept, and an example how to have an ultra-narrow "checkout" of the notes ref's tree.

Ciao, Dscho