git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] rebase -i -p: Fix --continue after a merge could not be redone

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 22, 2008, 21:16 UTC
Message-ID
<alpine.DEB.1.00.0812222215170.30769@pacific.mpi-cbg.de>
In-Reply-To
<alpine.DEB.1.00.0812222139340.30769@pacific.mpi-cbg.de>
Hi,
On Mon, 22 Dec 2008, Johannes Schindelin wrote:
Show 5 quoted lines
> I'll leave the commit message fixing to you, but the --cc patch probably 
> looks something like this -- feel free to squash in:
> 
> ---
> [... a patch ...]

Ooops. Scratch that. I tested without running the test suite, and sure enough, it failed. Take that instead.

--
 git-rebase--interactive.sh |   18 +++++++++++++++---
 1 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 89c39eb..f08409c 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -115,9 +115,21 @@ mark_action_done () {
 }
 
 make_patch () {
-	parent_sha1=$(git rev-parse --verify "$1"^) ||
-		die "Cannot get patch for $1^"
-	git diff-tree -p "$parent_sha1".."$1" > "$DOTEST"/patch
+	sha1_and_parents="$(git rev-list --parents -1 $1)"
+	case "$sha1_and_parents" in
+	*' '*' '*' '*)
+		echo "Octopus merge"
+	;;
+	*' '*' '*)
+		git diff --cc $sha1_and_parents
+	;;
+	*' '*)
+		git diff-tree -p $1^!
+	;;
+	*)
+		echo "Root commit"
+	;;
+	esac > "$DOTEST"/patch
 	test -f "$DOTEST"/message ||
 		git cat-file commit "$1" | sed "1,/^$/d" > "$DOTEST"/message
 	test -f "$DOTEST"/author-script ||
Previous: Johannes Schindelin
Message 6 of 6 in “Show a failure of rebase -p if the merge had a conflict”
  1. Show a failure of rebase -p if the merge had a conflictJohannes Sixt, Dec 11, 2008
  2. 1/2 Show a failure of rebase -p if the merge had a conflictJohannes Sixt, Dec 15, 2008
  3. 2/2 rebase -i -p: Fix --continue after a merge could not be redoneJohannes Sixt, Dec 15, 2008
  4. Junio C HamanoDec 15, 2008
  5. Johannes SchindelinDec 22, 2008
  6. Johannes SchindelinDec 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.