Re: Annotating patches inside diff

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 10, 2008, 16:58 UTC
Message-ID: <alpine.DEB.1.00.0812101755480.25069@eeepc-johanness>
In-Reply-To: <200812101445.48034.jnareb@gmail.com>

Hi,

On Wed, 10 Dec 2008, Jakub Narebski wrote:

Show 21 quoted lines

> I remember that long time ago on git mailing list there was discussed 
> extending git-apply and friends (including git-am), to be able to 
> ignore lines in patches with selected special prefix, different from 
> '@' for chunks headers, ' ' for context, '+'/'-' for added/deleted 
> lines.  IIRC it was chose '|' for this purpose.
> 
> This way you could annotate patch
> 
> @@ -4667,7 +4667,6 @@ HTML
>                                   hash_base => $parent_commit);
>                 print "<td class=\"linenr\">";
>                 print $cgi->a({ -href => "$blamed#l$orig_lineno",
> | moved to <tr>
> -                               -id => "l$lineno",
>                                 -class => "linenr" },
>                               esc_html($lineno));
>                 print "</td>";
> 
> 
> Was it accepted or dropped, or is this feature present but not 
> documented?

As I said on IRC, I think that if you are too good in the hiding-comments business, you can just spare the time to write them, 'cause nobody will find them.

IOW such a comment needs to go either into the commit message (if it is an important API change), so that people who do not remember discussions on the mailing list still have a chance to find the comment, or between the message and the diffstat (if it is less important).

Ciao, Dscho