Re: git-bpush: Pushing to a bundle

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 9, 2008, 10:07 UTC
Message-ID: <alpine.DEB.1.00.0812091100470.2916@eeepc-johanness>
In-Reply-To: <adf1fd3d0812090149m158fcb9as15bacce58c61a1a3@mail.gmail.com>

Hi,

On Tue, 9 Dec 2008, Santi Béjar wrote:

Show 5 quoted lines

> The basic idea is:
> 
> - Easily create bundles with the current branch.
> - Be able to push to defined bundles in remote.<remote>.url
> - Only add new objects by default (do not lose objects)

That is probably not what people need. Usually, when bundles are sent around, you need _incremental_ bundles. IOW if you already have a bundle, you want to create a new bundle that contains everything that is new, _in addition_ to the existing bundle.

> while [ $# != 0 ] ; do

Heh, I did not realize just how _used_ I got to the conventions in Git's shell programming, until I thought "Should this not use 'test' instead of brackets?"

> while [ $# != 0 ] ; do
>     refs="$refs$LF$1" && shift
> done

That is equivalent to refs="$*", no?

Anyway, I found reading your shell script quite hard, because of excessive use of brackets and single line && chains (which lack proper error handling, BTW).

Ciao, Dscho