git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitk: fix 'can't read "notflag"'

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 4, 2008, 14:34 UTC
Message-ID
<alpine.DEB.1.00.0812041532160.7045@racer>
In-Reply-To
<gh5q1t$qjn$1@ger.gmane.org>

Sometimes, when calling git bisect visualize, parameters including a "--not" are passed to gitk, triggering an uninitialized-variable bug introduced in ee66e089(gitk: Make updates go faster).

Noticed by Alejandro Riveira Fernández.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
	On Wed, 3 Dec 2008, Alejandro Riveira wrote:
	> $ git bisect visualize                                                                  (03-12 12:16)
	> Error in startup script: can't read "notflag": no such variable
	Alejandro was good enough to test this fix.
 gitk-git/gitk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 3353f4a..b18bdf0 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -139,6 +139,7 @@ proc parseviewargs {n arglist} {
     set origargs $arglist
     set allknown 1
     set filtered 0
+    set notflag 0
     set i -1
     foreach arg $arglist {
 	incr i
-- 
1.6.0.4.1189.g8876f
Previous: Alejandro RiveiraNext: Johannes Schindelin
Message 2 of 4 in “[BUG] git bisect visualize crash”
  1. Alejandro RiveiraDec 3, 2008
  2. gitk: fix 'can't read "notflag"'Johannes Schindelin, Dec 4, 2008
  3. Johannes SchindelinDec 4, 2008
  4. Johannes SixtDec 4, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.