git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/8] generate-cmdlist.sh: avoid selecting synopsis at wrong place

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 1, 2008, 14:10 UTC
Message-ID
<alpine.DEB.1.00.0812011505551.30769@pacific.mpi-cbg.de>
In-Reply-To
<1228042478-1886-2-git-send-email-pclouds@gmail.com>
Hi,
On Sun, 30 Nov 2008, Nguy�n Th�i Ng�c Duy wrote:
> In "common" man pages there is luckily no "NAME" anywhere except at 
> beginning of documents. If there is another "NAME", sed could mis-select 
> it and lead to common-cmds.h corruption. So better nail it at beginning 
> of line, which would reduce corruption chance.
I have no idea why you put this into the sparse checkout patch series.

As it is, the patch series is _already_ hard to review (as it is large not only in term of number of patches, but also individual patch size), _especially_ given the fact that there is no clear, precise and short description of why/how the sparse checkout is implemented.

For example, instead of using the BLURP area of the cover letter to put forth convincing arguments why this is needed, and why it is implemented in the best possible manner, you wasted two lines stating the obvious.

IMO that is almost like _asking_ people not to have a look at it.

Ciao, Dscho

Previous: Nguyễn Thái Ngọc DuyNext: Nguyen Thai Ngoc Duy
Message 10 of 13 in “Sparse checkout, the last half of the series”
  1. 0/8 Sparse checkout, the last half of the seriesNguyễn Thái Ngọc Duy, Nov 30, 2008
  2. 1/8 generate-cmdlist.sh: avoid selecting synopsis at wrong placeNguyễn Thái Ngọc Duy, Nov 30, 2008
  3. 2/8 Introduce "sparse patterns"Nguyễn Thái Ngọc Duy, Nov 30, 2008
  4. 3/8 unpack_trees(): keep track of unmerged entriesNguyễn Thái Ngọc Duy, Nov 30, 2008
  5. 4/8 unpack_trees(): add support for sparse checkoutNguyễn Thái Ngọc Duy, Nov 30, 2008
  6. 5/8 clone: support sparse checkout with --sparse-checkout optionNguyễn Thái Ngọc Duy, Nov 30, 2008
  7. 6/8 checkout: add new options to support sparse checkoutNguyễn Thái Ngọc Duy, Nov 30, 2008
  8. 7/8 Introduce default sparse patterns (core.defaultsparse)Nguyễn Thái Ngọc Duy, Nov 30, 2008
  9. 8/8 wt-status: show sparse checkout infoNguyễn Thái Ngọc Duy, Nov 30, 2008
  10. Johannes SchindelinDec 1, 2008
  11. Nguyen Thai Ngoc DuyDec 1, 2008
  12. Junio C HamanoDec 1, 2008
  13. Johannes SchindelinDec 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.