git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] Simplify and fix t9301

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Nov 23, 2008, 11:55 UTC
Message-ID
<alpine.DEB.1.00.0811231254580.30769@pacific.mpi-cbg.de>
In-Reply-To
<1227378168-14992-1-git-send-email-vmiklos@frugalware.org>

The recent addition to the test to show the tag related breakage was not minimal.

Further, it tested for the string "tag" at the start of the lines, which matches, "tagger", too. Test for "tag " instead.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
	I'll have no problem if this is squashed into Miklos' patch.
 t/t9301-fast-export.sh |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/t/t9301-fast-export.sh b/t/t9301-fast-export.sh
index 078832f..9af50b5 100755
--- a/t/t9301-fast-export.sh
+++ b/t/t9301-fast-export.sh
@@ -234,11 +234,8 @@ test_expect_success 'fast-export -C -C | fast-import' '
 test_expect_failure 'fast-export | fast-import when master is tagged' '
 
 	git tag -m msg last &&
-	rm -rf new &&
-	mkdir new &&
-	git --git-dir=new/.git init &&
 	git fast-export -C -C --signed-tags=strip --all > output &&
-	test $(grep -c "^tag" output) = 3
+	test $(grep -c "^tag " output) = 3
 
 '
 
-- 
1.6.0.2.749.g0cc32
Previous: Miklos VajnaNext: Johannes Schindelin
Message 3 of 6 in “git fast-export problem with tags”
  1. Miklos VajnaNov 22, 2008
  2. Add new testcase to show fast-export does not always exports all tagsMiklos Vajna, Nov 22, 2008
  3. 1/2 Simplify and fix t9301Johannes Schindelin, Nov 23, 2008
  4. 2/2 fast-export: use an unsorted string list for extra_refsJohannes Schindelin, Nov 23, 2008
  5. Miklos VajnaNov 23, 2008
  6. Junio C HamanoNov 24, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.