Re: [PATCH] mmap implementation for mingw.
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 21, 2008, 10:48 UTC
- Message-ID
- <alpine.DEB.1.00.0811211143550.30769@pacific.mpi-cbg.de>
- In-Reply-To
- <gg5t5s$qc8$1@ger.gmane.org>
Hi,
[re-Cc:ed j6t]
On Fri, 21 Nov 2008, Vasyl' Vavrychuk wrote:
Show 6 quoted lines
> [Dscho knows that j6t wrote this:] > > > It doesn't pass the test suite, for example t5301-sliding-window.sh > > fails. > > I will investigate.
Note that I quickly discarded the idea of mmap() on MinGW because at least in the past, we used to rename files that were mmap()ed. That is a no-go with CreateFile().
And I'd really like to see speed comparisons; AFAIR we had major issues with mmap() performance on MacOSX, and use lseek() && pread() for that particular code instead now.
Note that I find your work valuable, even if it should turn out that CreateFile() is slower, because at least we will know.
Thanks, Dscho