Re: [PATCH 3/3] builtin-branch: use strbuf in rename_branch()

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 19, 2008, 01:11 UTC
Message-ID: <alpine.DEB.1.00.0811190209470.30769@pacific.mpi-cbg.de>
In-Reply-To: <7vbpwcvb8i.fsf@gitster.siamese.dyndns.org>

Hi,

On Tue, 18 Nov 2008, Junio C Hamano wrote:

Show 9 quoted lines

> Miklos Vajna <vmiklos@frugalware.org> writes:
> 
> > -	snprintf(logmsg, sizeof(logmsg), "Branch: renamed %s to %s",
> > -		 oldref, newref);
> > +	strbuf_addf(&logmsg, "Branch: renamed %s to %s",
> > +		 oldref.buf, newref.buf);
> 
> I am wondering why nobody has complained until now, but shouldn't this 
> be oldname and newname?

I think that was the intention.  Lars?

Ciao, Dscho