Re: Pull request for sub-tree merge into /contrib/gitstats

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 3, 2008, 06:33 UTC
Message-ID: <alpine.DEB.1.00.0811030729071.22125@pacific.mpi-cbg.de.mpi-cbg.de>
In-Reply-To: <bd6139dc0811021124q5ba22d6bm6655f735aaeb379b@mail.gmail.com>

Hi,

On Sun, 2 Nov 2008, Sverre Rabbelier wrote:

Show 16 quoted lines

> On Thu, Oct 30, 2008 at 20:24, Junio C Hamano <gitster@pobox.com> wrote:
> > I have a mixed feeling about this.  From a longer-term perspective, do 
> > you really want this to be a part of git.git repository?
> 
> My main reason for wanting to have it in git.git is getting additional 
> exposure, being in /contrib seems like a good way to do that.
> 
> > I do not mind having notes to endorse and advocate "stats" as one of 
> > the "Third party packages that may make your git life more 
> > pleasuable", just like tig, stgit, guilt and topgit, but I cannot 
> > convince myself that merging it as a subtree is the right thing to do 
> > at this point.
> 
> Heh, blame Johannes for that one; the main reason for not doing 
> something like this earlier was my uncertaincy as to -what- to do. Dscho 
> suggested to request-pull a subtree merge, which is what I did.

Actually, I suggested that the end result be submitted as a single patch against contrib/, but dsymonds objected that that would lose all history, and I concurred that it would be nice to have all changes with the design decisions recorded as commit messages, too.

Actually, in the meantime, I am of two minds. On the one hand, I would just like to have the scripts in contrib/ (as a result of one commit), and on the other hand, I would not like to lose history of gitstats.

So I roll the ball back into your (Junio's) half, albeit gently.

Ciao, Dscho