Re: [PATCH] run-command.c: remove run_command_v_opt_cd()
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 2, 2008, 11:09 UTC
- Message-ID
- <alpine.DEB.1.00.0810021304360.22125@pacific.mpi-cbg.de.mpi-cbg.de>
- In-Reply-To
- <20081002191425.6117@nanako3.lavabit.com>
Hi,
On Thu, 2 Oct 2008, Nanako Shiraishi wrote:
> This function is not used anywhere.
I have to say that it fills me with sorrow, seeing that the direction these patches take is the _opposite_ of libifying Git. So far I was only disappointed that nobody pushed this goal, but now I am concerned that anybody thinking about it is actively discouraged.
Just think about Git Cheetah: if it were ever to benefit from an official libgit, then the function you remove would be _ideal_. By removing that function, you make it even less attractive to try to use Git as a proper library.
Ciao, Dscho