Re: [PATCH] xdiff-interface.c: strip newline (and cr) from line before pattern matching
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 1, 2008, 20:05 UTC
- Message-ID
- <alpine.DEB.1.00.0810012204280.22125@pacific.mpi-cbg.de.mpi-cbg.de>
- In-Reply-To
- <o5dqpNECJusQHKCTvRWiIqN2ZJ7w-fyC-0vM99FajJIgLsOwP3RNug@cipher.nrlssc.navy.mil>
Hi,
On Wed, 1 Oct 2008, Brandon Casey wrote:
Show 13 quoted lines
> POSIX doth sayeth: > > "In the regular expression processing described in IEEE Std 1003.1-2001, > the <newline> is regarded as an ordinary character and both a period and > a non-matching list can match one. ... Those utilities (like grep) that > do not allow <newline>s to match are responsible for eliminating any > <newline> from strings before matching against the RE." > > Thus far git has not been removing the trailing newline from strings matched > against regular expression patterns. This has the effect that (quoting > Jonathan del Strother) "... a line containing just 'FUNCNAME' (terminated by > a newline) will be matched by the pattern '^(FUNCNAME.$)' but not > '^(FUNCNAME$)'", and more simply not '^FUNCNAME$'.
Personally, I find the second paragraph pretty convincing. Which is good, because the first fails to do that.
Ciao, Dscho