git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Use GIT_COMMITTER_IDENT instead of hardcoded values in import-tars.perl

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Sep 8, 2008, 14:51 UTC
Message-ID
<alpine.DEB.1.00.0809081649040.13830@pacific.mpi-cbg.de.mpi-cbg.de>
In-Reply-To
<1220777531-28934-1-git-send-email-mh@glandium.org>
Hi,
On Sun, 7 Sep 2008, Mike Hommey wrote:
Show 5 quoted lines
> -my $committer_name = 'T Ar Creator';
> -my $committer_email = 'tar@example.com';
> +chomp(my $committer_ident = `git var GIT_COMMITTER_IDENT`);
> +die 'You need to set user name and email'
> +	unless ($committer_ident =~ s/(.+ <[^>]+>).*/\1/);
I have at least one script that will be broken by this change in behavior.

To me, the issue is just like git-cvsimport, which sets the committer not to the actual committer, so that two people can end up with identical commit names, even if they cvsimported independently. I'd like the same behavior for import-tars. I actually use it that way.

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 6 in “Use user.name and user.email in import-tars.perl”
  1. Use user.name and user.email in import-tars.perlMike Hommey, Feb 24, 2008
  2. Junio C HamanoFeb 24, 2008
  3. Use GIT_COMMITTER_IDENT instead of hardcoded values in import-tars.perlMike Hommey, Sep 7, 2008
  4. Junio C HamanoSep 7, 2008
  5. Johannes SchindelinSep 8, 2008
  6. Junio C HamanoSep 8, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.