Re: [PATCH] Preserve cwd in setup_git_directory()

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 25, 2008, 10:04 UTC
Message-ID: <alpine.DEB.1.00.0807251203001.11976@eeepc-johanness>
In-Reply-To: <93c3eada0807250248l60c81090sd1953df24cca1421@mail.gmail.com>

Hi,

On Fri, 25 Jul 2008, Geoff Russell wrote:

Show 5 quoted lines

> I was pretty surprised to find that my command line switch (--work-tree) 
> was being stored in the config file, which ended up causing the problem.  
> Duy thinks he can fix this, which is fine, but as a matter of principle, 
> I'm not keen on command line switches being magically saved for me when 
> I didn't ask for this to happen.

You were initializing a repository. How on earth could you be surprised when _important_ things like work-tree git-dir or if it is bare are stored inside the freshly initialized repository?

> The reason for using a command line switch is because I want to override 
> default behaviour on this execution, if I wanted to change the default 
> behaviour, then I'd set values in the config file.

No, you would not.  Because there is no config file yet.

Htrh, Dscho