Re: [PATCH] git-filter-branch.sh: Allow running in bare repositories

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 22, 2008, 23:27 UTC
Message-ID: <alpine.DEB.1.00.0807230025050.8986@racer>
In-Reply-To: <20080722223710.29084.61373.stgit@localhost>

Hi,

On Wed, 23 Jul 2008, Petr Baudis wrote:

> Commit 46eb449c restricted git-filter-branch to non-bare repositories
> unnecessarily; git-filter-branch can work on bare repositories just
> fine.

I think this is fine.

> This also fixes suspicious shell boolean expression during a check
> for dirty working tree.

If you are talking about X && Y || Z, it is well established (and should not be suspicious to a shell hacker like the creator of Cogito) that Z is executed if either X fails, or X succeeds and Y fails.

> +test_expect_success 'rewrite bare repository identically' '
> +	(git config core.bare true && cd .git && git-filter-branch branch)
> +'
> +git config core.bare false

Any reason why this is done outside the test?

Ciao, Dscho