git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix buffer overflow in git-grep

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 16, 2008, 14:47 UTC
Message-ID
<alpine.DEB.1.00.0807161546240.8950@racer>
In-Reply-To
<37fcd2780807160733o156e49c6m51314ff18764ccd5@mail.gmail.com>
Hi,
On Wed, 16 Jul 2008, Dmitry Potapov wrote:
Show 13 quoted lines
> On Wed, Jul 16, 2008 at 3:54 PM, Dmitry Potapov <dpotapov@gmail.com> wrote:
> >
> > For instance, git show will show you nothing at all and exit with 0.
> > The same problem with git whatchanged. The whole history mysteriously
> > disappeared at that commit, and git whatchanged exited with 0 without
> > any error or warning... Though git log will show you all history, but
> > if you run it with -p then it will also exit with zero at this commit
> > silently like previously history do not exist at all.
> 
> It turned out that git actually crashed while doing diff, but because it
> was a forked process, the parent exited normally with code 0. I wonder
> should not the parent process to exit with a non-zero code if the child
> died by SIGSEG or another signal?

We'll probably need to use the MinGW pager handling for Unix, too, and check for a died child.

Not overly trivial, though.

Ciao, Dscho

Previous: Dmitry PotapovNext: Dmitry Potapov
Message 5 of 10 in “Fix buffer overflow in git-grep”
  1. Fix buffer overflow in git-grepDmitry Potapov, Jul 16, 2008
  2. Johannes SchindelinJul 16, 2008
  3. Dmitry PotapovJul 16, 2008
  4. Dmitry PotapovJul 16, 2008
  5. Johannes SchindelinJul 16, 2008
  6. Fix buffer overflow in git diffDmitry Potapov, Jul 16, 2008
  7. Fix buffer overflow in prepare_attr_stackDmitry Potapov, Jul 16, 2008
  8. Johannes SixtJul 16, 2008
  9. Fix buffer overflow in prepare_attr_stackDmitry Potapov, Jul 16, 2008
  10. Fix buffer overflow in git-grepDmitry Potapov, Jul 16, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.