Re: [HACK] t/test-lib.sh HACK: Add -s/--show-hack to test suite.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 13, 2008, 00:25 UTC
Message-ID: <alpine.DEB.1.00.0807130222320.2995@eeepc-johanness>
In-Reply-To: <20080712222212.GC22323@leksak.fem-net>

Hi,

On Sun, 13 Jul 2008, Stephan Beyer wrote:

Show 24 quoted lines

> Johannes Schindelin wrote:
> 
> > On Mon, 7 Jul 2008, Stephan Beyer wrote:
> > 
> > > > > This option realizes a stupid hack that tries to run the test 
> > > > > cases line by line (separated by &&).
> > > > 
> > > > In what way is that better than "sh -x t????-*.sh"?
> > > 
> > > Your suggestion is more like "./t????-*.sh -v" instead of -s, at 
> > > least on bash and dash here.
> > 
> > No, I meant without "-v".
> 
> Me, too.
> 
> I've written something different: "sh -x" is a great thing and does 
> exactly what it should on simple scripts containing:
> 
> 	foo &&
> 	bar &&
> 	baz
> 
> But for a test case in the git test suite it does not work, unfortunately.

Huh?

When I run "sh -x t*.sh", it lists _every_ command that was executed in the script, and even more: it shows me the result, too! If there was a function that was called, it prefixes an additional "+" so that I can follow recursion better.

All in all, "sh -x" is a very versatile tool.

As far as I undertood your commit message, your HACK would have done the first part: list what commands were executed. This is less than what "sh -x" does.

Please clarify, Dscho