Re: [PATCH 1/3] t3404: slight improvements

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 20, 2008, 13:05 UTC
Message-ID: <alpine.DEB.1.00.0806201404020.6439@racer>
In-Reply-To: <1213929935-15093-2-git-send-email-s-beyer@gmx.net>

Hi,

On Fri, 20 Jun 2008, Stephan Beyer wrote:

> This patch adds some extra checks into some
> test cases and changes "! git ..." into
> "test_must_fail git".

I think your oneline should read "t3404: be more anal".

Show 12 quoted lines

> diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
> index e6f3fad..daba5fd 100755
> --- a/t/t3404-rebase-interactive.sh
> +++ b/t/t3404-rebase-interactive.sh
> @@ -107,7 +107,8 @@ chmod a+x fake-editor.sh
>  
>  test_expect_success 'no changes are a nop' '
>  	git rebase -i F &&
> -	test $(git rev-parse I) = $(git rev-parse HEAD)
> +	test $(git rev-parse I) = $(git rev-parse HEAD) &&
> +	test "$(git symbolic-ref -q HEAD)" = "refs/heads/branch2"
>  '

You could have saved some diff-screen-estate by putting the extra check _before_ the original one.

Other than that, I think this patch is fine.

Ciao, Dscho