Re: [PATCH] builtin-rerere: fix a small leak

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 17, 2008, 10:34 UTC
Message-ID: <alpine.DEB.1.00.0806171133330.6439@racer>
In-Reply-To: <7vk5go7cek.fsf@gitster.siamese.dyndns.org>

Hi,

On Tue, 17 Jun 2008, Junio C Hamano wrote:

Show 9 quoted lines

> The data read from MERGE_RR file is kept in path-list by hanging textual
> 40-byte conflict signature to path of the blob that contains the
> conflict.  The signature is strdup'ed twice, and the second copy is given
> to the path-list, leaking the first copy.
> 
> Signed-off-by: Junio C Hamano <junio@pobox.com>
> ---
>  * Am I overlooking something obvious, or is this simply a never-reviewed
>    buglet that nobody has noticed for a long time?

I think that it was a never-reviewed buglet. The only code path leading to read_rr passes merge_rr, which has strdup_paths == 1.

Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>

Ciao, Dscho