Re: [PATCH] git-apply doesn't handle same name patches well [V2]
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 17, 2008, 09:30 UTC
- Message-ID
- <alpine.DEB.1.00.0806171027200.6439@racer>
- In-Reply-To
- <1213633441-29185-1-git-send-email-dzickus@redhat.com>
Hi,
On Mon, 16 Jun 2008, Don Zickus wrote:
Show 5 quoted lines
> Changes since v1 > ================ > - converted to path-list structs > - added testcases for renaming a patch and apply a new patch on top inside > the same patch file
Just for future reference: commonly, this is not put into the commit message, but after the "---" separator into the mail comments.
Show 9 quoted lines
> +/*
> + * Caches patch filenames to handle the case where a
> + * patch chunk reuses a filename
> + */
> +struct fn_cache {
> + char *name;
> + struct patch *patch;
> + struct fn_cache *next;
> +};It is still not a path_list. Even if you said so in the "Changes since V1".
See http://repo.or.cz/w/git/vmiklos.git?a=blob;f=Documentation/technical/api-path-list.txt;h=9dbedd0a67ce6c1cecd157b0d89f9b1333e180e3;hb=340d6344cfe13bb93740f40d3268ca39b8c7c15d#l36 for a nice example how to use path_lists.
You want to use path_list_has_path().
Hth, Dscho