Re: [PATCH] Use nonrelative paths instead of absolute paths for cloned repositories
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 6, 2008, 17:34 UTC
- Message-ID
- <alpine.DEB.1.00.0806061832330.1783@racer>
- In-Reply-To
- <7viqwmv7ff.fsf@gitster.siamese.dyndns.org>
Hi,
On Fri, 6 Jun 2008, Junio C Hamano wrote:
Show 12 quoted lines
> In the longer term, we would inevitably face "when should one use > nonrelative and when should one use absolute?" and we would eventually > have to answer it. It may turn out that many current users of > "absolute" are better off using "nonrelative", but I suspect we won't > get rid of "absolute" completely, because one of the reasons it avoids > symlinks at great lengths is so that it can check the containment > relationships between paths reliably (e.g. "is this path outside the > repository, in which case we should refuse to add it to the index, and > we use --no-index without being asked when running "diff""). > > But using "absolute" for containment comparison is one thing. Storing > the result of "absolute" is quite another.
The easy way would be to add an option to make_absolute_path(), say "resolve_symlinks".
Ciao, Dscho