Re: [PATCH] builtin-fast-export: Add importing and exporting of revision marks

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 5, 2008, 13:31 UTC
Message-ID: <alpine.DEB.1.00.0806051429300.21190@racer>
In-Reply-To: <BEF1F17D-6F0F-4F09-9CC4-B193B8907901@ai.rug.nl>

Hi,

On Thu, 5 Jun 2008, Pieter de Bie wrote:

Show 7 quoted lines

> On 5 jun 2008, at 02:00, Johannes Schindelin wrote:
> 
> >Is "- (uint32_t *)NULL" needed?
> 
> I changed the uintmax_t to to a uint32_t. If I remove the "- (uint32_t
> *)NULL", it won't return the same marks. The same is done in 
>  get_object_mark().

Ah, I missed that again. I think I had exactly the same issue (of not understanding) with another patch for the same area of the code.

Maybe it would be worth having two functions to describe what is done there, for documentation purposes?

> I will send an updated patch.

Thanks, Dscho