Re: [RFC PATCH] git-add--interactive: manual hunk editing mode v2

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 5, 2008, 10:28 UTC
Message-ID: <alpine.DEB.1.00.0806051126060.21190@racer>
In-Reply-To: <20080605085605.GA16624@sigill.intra.peff.net>

Hi,

On Thu, 5 Jun 2008, Jeff King wrote:

Show 8 quoted lines

> I think there are two extremes here:
> 
>  1. We provide a very limited interface. E.g., you pick a line to 
>     arbitrarily split the hunk.
> 
>  2. We provide a very flexible interface. You get dumped in your editor 
>     with the hunk text, and we try to apply the result. Powerful, but 
>     easy to shoot yourself in the foot.

We have a tradition of giving the users plenty of rope.

And I actually like having the power at my finger tips. You would not believe how I enjoyed using "git add -e" to commit the final version of that very patch.

I, for one, will probably use this feature almost exclusively, _especially_ since I look at the diffs before committing _anyway_, and I cannot count the times when I had to go to another window to fix up a stupid debug message or typo. Now I will do that right away, and be done with it. I can even stash the debug messages for future use!

Ciao, Dscho