Re: git remote rename, why dosen't it exists?

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 5, 2008, 04:30 UTC
Message-ID: <alpine.DEB.1.00.0806050529350.21190@racer>
In-Reply-To: <1212634394.13109.10.camel@mithrandir.bogado.net>

Hi,

On Wed, 4 Jun 2008, Victor Bogado da Silva Lins wrote:

Show 11 quoted lines

> On Wed, 2008-06-04 at 16:51 +0100, Johannes Schindelin wrote:
>
> > On Wed, 4 Jun 2008, Victor Bogado da Silva Lins wrote:
> > 
> > > I trying to refactor [in builtin-remote.c] rm into rm_or_rename, but 
> > > I stumbled into a problem, how do I free a remote struct obtained 
> > > with "remote_get"?
> 
> It seems that git-remote thinks that remote_get will return NULL if
> there is no such remote, but in fact it does not do this, it always
> alloc a new remote struct and returns that newly allocated.

>From remote.c, remote_get(), line 601--602 in my checkout:

        if (!ret->url)
                return NULL;

Hth, Dscho