Re: [PATCH] builtin-apply: Show a more descriptive error on failure when opening a patch
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 14, 2008, 14:03 UTC
- Message-ID
- <alpine.DEB.1.00.0804141502590.28504@racer>
- In-Reply-To
- <1208112991-21598-1-git-send-email-albertito@gmail.com>
Hi,
On Sun, 13 Apr 2008, Alberto Bertogli wrote:
Show 14 quoted lines
> diff --git a/builtin-apply.c b/builtin-apply.c
> index abe73a0..d80b231 100644
> --- a/builtin-apply.c
> +++ b/builtin-apply.c
> @@ -3120,8 +3120,11 @@ int cmd_apply(int argc, const char **argv, const char *unused_prefix)
> arg = prefix_filename(prefix, prefix_length, arg);
>
> fd = open(arg, O_RDONLY);
> - if (fd < 0)
> - usage(apply_usage);
> + if (fd < 0) {
> + perror("Error opening patch");
> + return 1;
> + }Would "return error("...: '%s'", arg);" not be much more appropriate and consistent with the resto of the source code?
Ciao, Dscho