RE: [PATCH] Add svnrdump

From: Daniel Shahaf <d.s@daniel.shahaf.name>
Date: Jul 8, 2010, 08:17 UTC
Message-ID: <alpine.561.2.00.1007081113210.3936@daniel2.local>
In-Reply-To: <002d01cb1e7f$e0ff03c0$a2fd0b40$@nl>

@Bert: could you please trim quoted patches to only the relevant parts? Scrolling is tedious when I don't have have line folding available...

Bert Huijben wrote on Thu, 8 Jul 2010 at 12:28 -0000:

Show 9 quoted lines

> > -----Original Message-----
> > From: Ramkumar Ramachandra [mailto:artagnon@gmail.com]
> > Sent: donderdag 8 juli 2010 10:35
> > To: dev@subversion.apache.org
> > Cc: Jonathan Nieder; Sverre Rabbelier; Git Mailing List
> > Subject: [PATCH] Add svnrdump
> > 
> > +  /* Use a temporary file to measure the text-content-length */
> > +  apr_err = apr_temp_dir_get(&tempdir, hb->pool);

svn_io_temp_dir()

Show 6 quoted lines

> > +  if (apr_err != APR_SUCCESS)
> > +    SVN_ERR(svn_error_wrap_apr(apr_err, NULL));
> > +
> > +  hb->temp_filepath = apr_psprintf(eb->pool, "%s/svn-fe-XXXXXX",
> > tempdir);
>

os.path.join()

Err, I mean, svn_dirent_join().