Re: [PATCH 5/5] use repo_hold_lock_file_for_update{,_mode,_timeout}() with custom repos
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jul 15, 2026, 09:52 UTC
- Message-ID
- <aldYW4TPUqgDMRcf@pks.im>
- In-Reply-To
- <20260714175956.54601-6-l.s.r@web.de>
On Tue, Jul 14, 2026 at 07:59:56PM +0200, René Scharfe wrote:
> Apply the config setting core.sharedRepository from the repository at > hand instead of from the_repository.
We only do this for a subset of callsites, apparently. How did you select which subsystems to convert and which not to? To make this explicit: I don't mind a partial migration, but I think the commit message should briefly explain the reasoning behind it.
Also, as you don't get rid of the old functions that still implicitly depend on `the_repository`, I think we should have an additional commit on top that guards all functions that have this implicit dependency with `USE_THE_REPOSITORY_VARIABLE`. This ensures that we cannot accidentally call such functions from other subsystems that already got rid of the global dependency.
Thanks!
Patrick