git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] remote-curl: simplify passing of push specs

From
Patrick Steinhardt <ps@pks.im>
Date
Jul 15, 2026, 06:41 UTC
Message-ID
<alcrhGUCVMCnm2-i@pks.im>
In-Reply-To
<935883f3-3be4-4c51-9711-5208b9ef9ca1@web.de>
On Wed, Jul 15, 2026 at 06:41:17AM +0200, René Scharfe wrote:
Show 16 quoted lines
> diff --git a/remote-curl.c b/remote-curl.c
> index 9e614c5567..2c35dd5240 100644
> --- a/remote-curl.c
> +++ b/remote-curl.c
> @@ -1340,10 +1340,9 @@ static void parse_get(const char *arg)
>  	fflush(stdout);
>  }
>  
> -static int push_dav(int nr_spec, const char **specs)
> +static int push_dav(const char **specs)
>  {
>  	struct child_process child = CHILD_PROCESS_INIT;
> -	size_t i;
>  
>  	child.git_cmd = 1;
>  	strvec_push(&child.args, "http-push");

I wonder whether the interface would be even better if we simply passed around a `const struct strvec *` directly. That makes it explicit what kind of guarantees we have, and all transitive callers already have one available anyway.

Show 7 quoted lines
> @@ -1353,15 +1352,14 @@ static int push_dav(int nr_spec, const char **specs)
>  	if (options.verbosity > 1)
>  		strvec_push(&child.args, "--verbose");
>  	strvec_push(&child.args, url.buf);
> -	for (i = 0; i < nr_spec; i++)
> -		strvec_push(&child.args, specs[i]);
> +	strvec_pushv(&child.args, specs);

I thought that we had something like `strvec_pushvec()` that knew to also optimize for this case so that we don't have to reallocate the vector multiple times. And if we had that function it would even be more efficient to pass it down the stack. But we seemingly don't have it, so that argument is kind of moot.

Other than those nits the patch looks good to me, thanks!
Patrick
Previous: René ScharfeNext: René Scharfe
Message 2 of 5 in “remote-curl: simplify passing of push specs”
  1. remote-curl: simplify passing of push specsRené Scharfe, Jul 15, 2026
  2. Patrick SteinhardtJul 15, 2026
  3. René ScharfeJul 15, 2026
  4. Patrick SteinhardtJul 16, 2026
  5. Junio C HamanoJul 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.