Re: [PATCH] fast-export: standardize usage string and SYNOPSIS
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jul 14, 2026, 08:54 UTC
- Message-ID
- <alX5Nl8uX4ctVqo3@pks.im>
- In-Reply-To
- <20260713124153.245268-1-christian.couder@gmail.com>
On Mon, Jul 13, 2026 at 02:41:53PM +0200, Christian Couder wrote:
Show 13 quoted lines
> diff --git a/Documentation/git-fast-export.adoc b/Documentation/git-fast-export.adoc > index 297b57bb2e..719aeca244 100644 > --- a/Documentation/git-fast-export.adoc > +++ b/Documentation/git-fast-export.adoc > @@ -9,7 +9,7 @@ git-fast-export - Git data exporter > SYNOPSIS > -------- > [verse] > -'git fast-export' [<options>] | 'git fast-import' > +'git fast-export' [<options>] [<revision-range>] [[--] <path>...] > > DESCRIPTION > -----------
Makes sense, as it is more consistent with all the other commands that we have. I don't recall any other commands that use "|".
Show 13 quoted lines
> diff --git a/builtin/fast-export.c b/builtin/fast-export.c
> index 0be43104dc..629d7c591a 100644
> --- a/builtin/fast-export.c
> +++ b/builtin/fast-export.c
> @@ -33,7 +33,7 @@
> #include "gpg-interface.h"
>
> static const char *const fast_export_usage[] = {
> - N_("git fast-export [<rev-list-opts>]"),
> + N_("git fast-export [<options>] [<revision-range>] [[--] <path>...]"),
> NULL
> };
> This is being adapted to match.
Show 12 quoted lines
> diff --git a/t/t0450/adoc-help-mismatches b/t/t0450/adoc-help-mismatches > index e8d6c13ccd..c4a55ff4e3 100644 > --- a/t/t0450/adoc-help-mismatches > +++ b/t/t0450/adoc-help-mismatches > @@ -12,7 +12,6 @@ column > credential > credential-cache > credential-store > -fast-export > fast-import > fetch-pack > fmt-merge-msg
And as both match now we can also update t0450. Nice!
Patrick