Re: cygwin v2.55.0 test failures

From: Patrick Steinhardt <ps@pks.im>
Date: Jul 13, 2026, 11:06 UTC
Message-ID: <alTGqS2_RmfGHvfV@pks.im>
In-Reply-To: <f65466c9-bede-472e-ad57-e72a5289be27@ramsayjones.plus.com>

On Fri, Jul 10, 2026 at 07:32:23PM +0100, Ramsay Jones wrote: [snip]

Show 10 quoted lines

> Note that Patrick wanted to have a clean test-suite run on cygwin, so in
> commit 5f8af25ff9 ("t5500, t5601: skip tests which exercise paths with '[::1]'
> on Cygwin", 2024-10-16), he suppressed the test failures in t5500 and t5601.
> (that was about the time of the v2.48.0 release).
> 
> The changes to tests t5500 and t5601, in the patch given below, essentially
> reverts Patrick's commit 5f8af25ff9. This fixes all of the tests in t5601 and
> ten of the twelve failures in t5500. (I don't recall what happened to t5580,
> the single failure - the push test - was fixed somewhere between v2.43.0 and
> v2.44.0-rc0).

Yeah, this was merely papering over issues. I'd very much welcome a revert and proper fix for this.

Show 9 quoted lines

> As luck would have it, I left a note to myself about the remaining two
> failure cases. This leads to the remaining hunk, to connect.c, in the patch
> below; ie. the removal of a conditional (which should only fire for GfW and
> cygwin). The '#ifdef DUMMY/#endif' should probably be replaced with an
> '#ifdef GIT_WINDOWS_NATIVE/#endif' so that GfW is not affected. (Having said
> that, I suspect that even GfW should drop it ['somebody was smoking something
> exotic'], but I have no way to test it, so ...).
> 
> With this final hunk, this patch results in a clean test-suite run. :)

Nice :)

By the way: I was pondering multiple times over whether or not we should add Cygwin to our CI matrix. It seems to be sufficiently different from both MSYS2 and native Win32 to have its own set of compatibility issues, so that could be worth it?

Show 5 quoted lines

>  connect.c             |  2 ++
>  git-compat-util.h     | 39 +++++++++++++++++++++++++++++++++++++++
>  t/t5500-fetch-pack.sh | 14 ++++----------
>  t/t5601-clone.sh      | 11 ++---------
>  4 files changed, 47 insertions(+), 19 deletions(-)

For the record: I don't really have much of an opinion on this given that I tend to not use Windows, except when I (once again) break some tests there. Especially the path handling si something that tends to cause lots of confusion on my side.

Patrick