Re: [PATCH] b4: include change-id in cover template
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jul 10, 2026, 08:46 UTC
- Message-ID
- <alCxgqybWb9eDEG0@pks.im>
- In-Reply-To
- <20260710-add-change-id-to-b4-template-v1-1-1bd37a25064e@black-desk.cn>
On Fri, Jul 10, 2026 at 03:22:13PM +0800, Chen Linxuan via B4 Relay wrote:
Show 17 quoted lines
> From: Chen Linxuan <me@black-desk.cn> > > With b4 0.15.2, I hit a local failure after sending a series with the > in-tree cover template. The generated sent/<change-id>-vN tag contained > base-commit, but did not contain change-id, and later b4 commands failed > when trying to read it: > > CRITICAL: Tag sent/... does not contain change-id info > > Looking at b4's source, the sent tag message is derived from the rendered > cover letter. The same code later parses that tag and expects both > base-commit and change-id to be present. The default b4 cover template > has both trailers, but our in-tree template only has base-commit. > > Add the missing change-id trailer next to base-commit so sent tags > produced from the project template remain readable by b4's reroll and > comparison logic.
Ah, that's indeed an oversight on my side. So this change looks good to me, thanks!
Patrick