git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/6] odb: make backend-specific fields optional

From
Patrick Steinhardt <ps@pks.im>
Date
Jun 30, 2026, 11:28 UTC
Message-ID
<akOoY4LKve0-ys9_@pks.im>
In-Reply-To
<akKmwPGSAGEGKZjL@denethor>
On Mon, Jun 29, 2026 at 12:25:21PM -0500, Justin Tobler wrote:
Show 20 quoted lines
> On 26/06/24 02:19PM, Patrick Steinhardt wrote:
> > diff --git a/builtin/cat-file.c b/builtin/cat-file.c
> > index 8726485f1f..adc626ce30 100644
> > --- a/builtin/cat-file.c
> > +++ b/builtin/cat-file.c
> > @@ -269,32 +301,20 @@ struct object_info {
> >  	 */
> >  	time_t *mtimep;
> >  
> > +	/*
> > +	 * Backend-specific information that tells the caller where exactly an
> > +	 * object was looked up from. This information should help disambiguate
> > +	 * object lookups in case the same object exists in multiple sources,
> > +	 * or multiple times in the same source.
> > +	 */
> > +	struct object_info_source *sourcep;
> 
> To me, the name `sourcep` makes me think a pointer to `struct
> odb_source`. This did confuse me slightly when initially reading, but
> I'm not sure it's worth it to be overly verbose here.

Yeah, good point. But as you say, I haven't been able to really come up with a name that is not overly verbose. We could potentially rename the structure itself to `odb_source_info` and then call the field itself `source_infop`. Would that help?

Patrick
Previous: Justin ToblerNext: Patrick Steinhardt
Message 7 of 26 in “odb: refactor source-specific information in object info”
  1. 0/6 odb: refactor source-specific information in object infoPatrick Steinhardt, Jun 24, 2026
  2. 1/6 packfile: thread odb_source_packed through packed_object_info()Patrick Steinhardt, Jun 24, 2026
  3. Justin ToblerJun 29, 2026
  4. Patrick SteinhardtJun 30, 2026
  5. 2/6 odb: make backend-specific fields optionalPatrick Steinhardt, Jun 24, 2026
  6. Justin ToblerJun 29, 2026
  7. Patrick SteinhardtJun 30, 2026
  8. 3/6 odb: add `source` field to struct object_info_sourcePatrick Steinhardt, Jun 24, 2026
  9. Justin ToblerJun 29, 2026
  10. Junio C HamanoJun 29, 2026
  11. Patrick SteinhardtJun 30, 2026
  12. Junio C HamanoJun 30, 2026
  13. 4/6 treewide: convert users of `whence` to the new source fieldPatrick Steinhardt, Jun 24, 2026
  14. Justin ToblerJun 29, 2026
  15. 5/6 odb: drop `whence` field from object infoPatrick Steinhardt, Jun 24, 2026
  16. Justin ToblerJun 29, 2026
  17. 6/6 odb: document object info fieldsPatrick Steinhardt, Jun 24, 2026
  18. Junio C HamanoJun 24, 2026
  19. 0/6 odb: refactor source-specific information in object infoPatrick Steinhardt, Jul 2, 2026
  20. 1/6 packfile: thread odb_source_packed through packed_object_info()Patrick Steinhardt, Jul 2, 2026
  21. 2/6 odb: make backend-specific fields optionalPatrick Steinhardt, Jul 2, 2026
  22. 3/6 odb: add `source` field to struct object_info_sourcePatrick Steinhardt, Jul 2, 2026
  23. 4/6 treewide: convert users of `whence` to the new source fieldPatrick Steinhardt, Jul 2, 2026
  24. 5/6 odb: drop `whence` field from object infoPatrick Steinhardt, Jul 2, 2026
  25. 6/6 odb: document object info fieldsPatrick Steinhardt, Jul 2, 2026
  26. Junio C HamanoJul 5, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.