git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] SubmittingPatches: document how to retract a topic

From
Michael Montalbo <mmontalbo@gmail.com>
Date
Jul 8, 2026, 18:23 UTC
Message-ID
<ak6U07K1dQPlXxIp@nixos>
In-Reply-To
<xmqqpl0xv25e.fsf@gitster.g>
On Wed, Jul 08, 2026 at 10:09:49AM -0700, Junio C Hamano wrote:
Show 42 quoted lines
> While this document outlines an idealized lifecycle where an author
> develops a patch, refines it with reviewer feedback, and
> successfully merges it into Git, reality is rarely so seamless.
> 
> Sometimes, a topic must be abandoned. Doing so explicitly is far
> better than leaving it in limbo, especially since topics can always
> be resurrected later.
> 
> Clearly state that we encourage contributors to retract any topic
> that does not pan out.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> 
>  * Added the third bullet that talks about when and how a topic
>    becomes stalled and discarded.
> 
>  Documentation/SubmittingPatches | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index d2d82eb543..c269e474e3 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -123,6 +123,20 @@ of review.
>    top, it gets merged to the 'master' branch and waits to become part
>    of the next major release.
>  
> +But sometimes things do not work as planned:
> +
> +. If a mailing list discussion convinces you that your changes aren't
> +  ideal, please explicitly retract the topic to save the maintainer
> +  time and effort.
> +
> +. If you must drop a topic due to shifting priorities, lack of time,
> +  or other commitments, notify the list as a courtesy so others can
> +  take over. Anyone can resurrect the topic later when they have the
> +  capacity to do so.
> +
> +. Topics with unaddressed review comments that remain inactive for
> +  four weeks may be discarded by the maintainer.
> +

Nice, I think these points read smoothly and the additional "four weeks until may be discarded" guidance is helpful.

LGTM.
Previous: Junio C Hamano
Message 3 of 3 in “SubmittingPatches: abandoning a series”
  1. SubmittingPatches: abandoning a seriesJunio C Hamano, Jul 8, 2026
  2. SubmittingPatches: document how to retract a topicJunio C Hamano, Jul 8, 2026
  3. Michael MontalboJul 8, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.