Re: [PATCH v2 2/2] reftable: fix quadratic behavior in the presence of tombstones
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jul 9, 2026, 13:53 UTC
- Message-ID
- <ak-n6K4heV2kHviZ@pks.im>
- In-Reply-To
- <c13f15ddc20f721443fa1d462ea1b7c2356fbffc.1783598912.git.gitgitgadget@gmail.com>
On Thu, Jul 09, 2026 at 12:08:31PM +0000, Kristofer Karlsson via GitGitGadget wrote:
Show 12 quoted lines
> diff --git a/reftable/stack.c b/reftable/stack.c > index ab12926708..fd7d8f3f1e 100644 > --- a/reftable/stack.c > +++ b/reftable/stack.c > @@ -337,7 +337,6 @@ static int reftable_stack_reload_once(struct reftable_stack *st, > /* Update the stack to point to the new tables. */ > if (st->merged) > reftable_merged_table_free(st->merged); > - new_merged->suppress_deletions = 1; > st->merged = new_merged; > > if (st->tables)
Okay, we still retain the field after this patch. But the question is: how would libgit2 now set it? I think we should rather extend the `struct reftable_stack_options` so that the caller can control whether or not to suppress deletions at stack creation time.
Thanks!
Patrick