git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitlab-ci: migrate Windows builds away from Chocolatey

From
Justin Tobler <jltobler@gmail.com>
Date
Jun 18, 2026, 14:03 UTC
Message-ID
<ajP5owy3r_GyuLqk@denethor>
In-Reply-To
<ajOE2XMBzgrXxbH8@pks.im>
On 26/06/18 07:40AM, Patrick Steinhardt wrote:
Show 18 quoted lines
> On Wed, Jun 17, 2026 at 03:03:39PM -0500, Justin Tobler wrote:
> > On 26/06/15 02:21PM, Patrick Steinhardt wrote:
> > >    before_script:
> > >      - *windows_before_script
> > > -    - choco install -y git meson ninja rust-ms
> > > -    - Import-Module $env:ChocolateyInstall\helpers\chocolateyProfile.psm1
> > > -    - refreshenv
> > > +    - ./ci/install-dependencies.ps1
> > > +    - $env:Path = "C:\Meson;C:\Rust\bin;$env:Path"
> > 
> > I assume Git is already discoverable on the path?
> 
> Good question -- in fact it's not, but in Meson we know to use the
> well-known path of "C:\Program Files\Git" automatically and that's why
> we don't have to add it here. That certainly is a bit hacky, but I'm not
> sure whether we need to change it.
> 
> Just let me know if you think so.

If it's only Meson that needs to locate Git and it is already capable of doing that without updating the path here, this is probably fine as-is. We could maybe explain this to future reader in a comment? But I'm not sure it matters too much and is likely not worth a reroll IMO.

Overall this patch looks good to me.
-Justin
Previous: Patrick Steinhardt
Message 4 of 4 in “gitlab-ci: migrate Windows builds away from Chocolatey”
  1. gitlab-ci: migrate Windows builds away from ChocolateyPatrick Steinhardt, Jun 15, 2026
  2. Justin ToblerJun 17, 2026
  3. Patrick SteinhardtJun 18, 2026
  4. Justin ToblerJun 18, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.