Re: [RFC PATCH] MyFirstContribution: mention trimming quoted text in replies
- From
- Weijie Yuan <wy@wyuan.org>
- Date
- Jun 12, 2026, 08:39 UTC
- Message-ID
- <aivFyBanzoHnYRsy@wyuan.org>
- In-Reply-To
- <xmqqcxxwljue.fsf@gitster.g>
On Thu, Jun 11, 2026 at 04:48:25PM -0700, Junio C Hamano wrote:
Show 22 quoted lines
> [...] > > diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc > > index 607876f3d8..0e2a9313ce 100644 > > --- a/Documentation/MyFirstContribution.adoc > > +++ b/Documentation/MyFirstContribution.adoc > > @@ -1453,6 +1453,11 @@ effect which had not occurred to you. It is always okay to ask for clarification > > if you aren't sure why a change was suggested, or what the reviewer is asking > > you to do. > > > > +When replying to review comments, quote only the parts of the message that are > > +relevant to your response. It is usually helpful to trim away unrelated context, > > +such as large portions of the patch that are not being discussed, while keeping > > +enough quoted text for readers to understand what you are responding to. > > + > > Make sure your email client has a plaintext email mode and it is turned on; the > > Git list rejects HTML email. Please also follow the mailing list etiquette > > outlined in the > > The insertion point is well chosen, immediately following the > discussion on how to handle review comments and before the technical > details of email client configuration. The text itself is clear and > gives sound advice.
Thank you for your reply.
I first considered folding this into one of the existing paragraphs above, but ended up making it a separate paragraph for better clarity. Let's see whether others have better wording suggestions.
Now the expectations for contributors and reviewers are more aligned when participating in review discussions :-)
Hopefully this addition will make review discussions a little easier to focus and reduce the burden on reviewers.
Thanks!