Re: [PATCH] gitattributes: fix eol attribute for Perl scripts
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jun 15, 2026, 07:22 UTC
- Message-ID
- <ai-oHtHFsyhnLDWA@pks.im>
- In-Reply-To
- <pull.2151.git.1781497525828.gitgitgadget@gmail.com>
On Mon, Jun 15, 2026 at 04:25:25AM +0000, Koutian Wu via GitGitGadget wrote:
Show 9 quoted lines
> From: ktwu01 <ktwu01@gmail.com> > > The *.pl pattern currently sets eof=lf, which is not a built-in > attribute used for line-ending normalization. > > Use eol=lf instead, matching the neighboring *.perl and *.pm rules, so > Perl scripts are checked out with LF line endings. > > Signed-off-by: ktwu01 <ktwu01@gmail.com>
The Signed-off-by and commit author should use your real name, if possible. See [1].
Show 13 quoted lines
> diff --git a/.gitattributes b/.gitattributes > index 556322be01..26490ad60a 100644 > --- a/.gitattributes > +++ b/.gitattributes > @@ -2,7 +2,7 @@ > *.[ch] whitespace=indent,trail,space,incomplete diff=cpp > *.sh whitespace=indent,trail,space,incomplete text eol=lf > *.perl text eol=lf diff=perl > -*.pl text eof=lf diff=perl > +*.pl text eol=lf diff=perl > *.pm text eol=lf diff=perl > *.py text eol=lf diff=python > *.bat text eol=crlf
Yeah, this looks obviously correct to me. Thanks for the fix!
Patrick
[1]: https://git-scm.com/docs/SubmittingPatches#real-name