Re: [PATCH 2/2] SubmittingPatches: describe cover letter
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jun 2, 2026, 12:07 UTC
- Message-ID
- <ah7HZuy_WRCD9ZZ-@pks.im>
- In-Reply-To
- <20260602090808.87837-3-gitster@pobox.com>
On Tue, Jun 02, 2026 at 06:08:08PM +0900, Junio C Hamano wrote:
> We talk about how a commit log message should look like, but do not > give advice on writing the cover letter to sell a series to widest
s/to widest/to the widest/?
Show 32 quoted lines
> possible audience. > > Signed-off-by: Junio C Hamano <gitster@pobox.com> > --- > Documentation/SubmittingPatches | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches > index dec8aea4cb..8ff1792b9b 100644 > --- a/Documentation/SubmittingPatches > +++ b/Documentation/SubmittingPatches > @@ -472,6 +472,25 @@ highlighted above. > Only capitalize the very first letter of the trailer, i.e. favor > "Signed-off-by" over "Signed-Off-By" and "Acked-by:" over "Acked-By". > > +[[cover-letter]] > +=== Cover Letter > + > +The purpose of your cover letter is to sell your changes, explain what > +they are about, and get your target audience interested enough to read > +the patches. > + > +. Make sure your target audience can understand what the patches are > + about and why they are needed without prior context. > + > +. For a second or subsequent iteration of the same topic, make sure > + people who missed the earlier discussion can still understand what > + the patches are about, so they can judge if the topic is worth their > + time to read and comment on. > + > +. To help those who are familiar with earlier iterations, give a > + summary of changes since the previous rounds.
We might also recommend to include a range-diff in subsequent iterations. That being said though, I just sent a small series to the mailing list that recommends using b4, and there it get this for free. So no idea whether it's still worth it to then cover this here explicitly.
Patrick