git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] some leak fixes on fs/ssh-signing-fix

From
Fabian Stelzer <fs@gigacodes.de>
Date
Oct 19, 2021, 08:16 UTC
Message-ID
<af0cf842-a16c-6cc3-fb61-b61422b24b17@gigacodes.de>
In-Reply-To
<YW2qpuosxr9PNwVa@coredump.intra.peff.net>
On 18.10.21 19:11, Jeff King wrote:
Show 12 quoted lines
> This fixes two small leaks on top of fs/ssh-signing-fix noticed by
> Coverity. I guess it's too late to squash them in, so I prepared patches
> on top.
> 
>   [1/2]: gpg-interface: fix leak of "line" in parse_ssh_output()
>   [2/2]: gpg-interface: fix leak of strbufs in get_ssh_key_fingerprint()
> 
>  gpg-interface.c | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> -Peff
> 

Thanks. Both of these look good.

Is coverity included in the ci/gh actions? Where would these notices show up?

Kind regards, Fabian

Previous: Jeff KingNext: Jeff King
Message 4 of 5 in “some leak fixes on fs/ssh-signing-fix”
  1. 0/2 some leak fixes on fs/ssh-signing-fixJeff King, Oct 18, 2021
  2. 1/2 gpg-interface: fix leak of "line" in parse_ssh_output()Jeff King, Oct 18, 2021
  3. 2/2 gpg-interface: fix leak of strbufs in get_ssh_key_fingerprint()Jeff King, Oct 18, 2021
  4. Fabian StelzerOct 19, 2021
  5. Jeff KingOct 19, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.