git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] shallow: remove unused variable

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
May 16, 2018, 22:10 UTC
Message-ID
<ae96f1c4-add2-d9d8-f08b-a765fe277232@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Stefan,

If you need to re-roll your 'sb/object-store-grafts' branch, could you please squash this into the relevant patch (whichever one that would be)! ;-)

I have not looked to see which patch needs to change (just being lazy, sorry!), but this variable was introduced by commit d73b49b707 ("shallow: migrate shallow information into the object parser", 2018-05-15).

That commit seems to rename the 'shallow_stat' symbol to the 'the_repository_shallow_stat' symbol, but at the same time adds an 'shallow_stat' field to the parsed_object_pool struct, so ... :(
Thanks!

ATB, Ramsay Jones

 shallow.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/shallow.c b/shallow.c
index 74bc78801..51447608a 100644
--- a/shallow.c
+++ b/shallow.c
@@ -17,8 +17,6 @@
 #include "commit-slab.h"
 #include "repository.h"
 
-struct stat_validity the_repository_shallow_stat;
-
 void set_alternate_shallow_file(struct repository *r, const char *path, int override)
 {
 	if (r->parsed_objects->is_shallow != -1)
-- 
2.17.0
Next: Stefan Beller
Message 1 of 2 in “shallow: remove unused variable”
  1. shallow: remove unused variableRamsay Jones, May 16, 2018
  2. Stefan BellerMay 16, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.