Re: [PATCH v1 1/1] git diff --quiet exits with 1 on clean tree with CRLF conversions

From

Torsten Bögershausen <tboegi@web.de>

Date

Mar 3, 2017, 17:02 UTC

Message-ID

<ae2b144a-5e39-8178-5161-1d8eb673b6f0@web.de>

In-Reply-To

<20170302200356.GA31318@mcrowe.com>

Understood, thanks for the explanation.

quiet is not quite any more..

Does the following fix help ?

--- a/diff.c
+++ b/diff.c
@@ -2826,6 +2826,8 @@ int diff_populate_filespec(struct diff_filespec *s,
unsigned int flags)
        enum safe_crlf crlf_warn = (safe_crlf == SAFE_CRLF_FAIL
                                    ? SAFE_CRLF_WARN
                                    : safe_crlf);
+       if (size_only)
+               crlf_warn = SAFE_CRLF_FALSE;