Re: [PATCH] submodule status: propagate SIGPIPE

From: phillip.wood123@gmail.com <phillip.wood123@gmail.com>
Date: Sep 21, 2024, 13:23 UTC
Message-ID: <ae114c58-2a9b-415a-9f47-312e4d080492@gmail.com>
In-Reply-To: <xmqqfrpuf5u7.fsf@gitster.g>

Hi Junio

On 20/09/2024 21:06, Junio C Hamano wrote:

Show 17 quoted lines

> "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
>> index a46ffd49b34..a8e497ef3c6 100644
>> --- a/builtin/submodule--helper.c
>> +++ b/builtin/submodule--helper.c
>> @@ -30,6 +30,7 @@
>>   #include "advice.h"
>>   #include "branch.h"
>>   #include "list-objects-filter-options.h"
>> +#include <signal.h>
> 
> Do we really need this?
> 
> As with any other Git built-in that relies on git-compat-util.h to
> handle such system-dependencies, direct inclusion of system headers
> like this is highly questionable.

Good point - I really need to figure out how to stop emacs' lsp mode automatically adding includes. I removed its "helpful" addition of <csignal> but forgot to remove <signal.h> as well.

Thanks

Phillip