Re: [RFC/PATCH 0/2] Support for arbitrary mapping for "git pull --rebase"

From: Santi Béjar <santi@agolina.net>
Date: Jun 19, 2009, 13:42 UTC
Message-ID: <adf1fd3d0906190642j383411e8ydf03b524abcc1875@mail.gmail.com>
In-Reply-To: <adf1fd3d0906180224l668b4c84kc633ec13f8d0296@mail.gmail.com>

2009/6/18 Santi Béjar <santi@agolina.net>:

Show 13 quoted lines

> 2009/6/18 Johannes Schindelin <Johannes.Schindelin@gmx.de>:
>> Hi,
>>
>> On Thu, 18 Jun 2009, Santi Béjar wrote:
>>
>>> Santi B??jar (2):
>>
>> Seems something is wrong in the --cover-letter utf-8 handlin, no?
>
> In this case (the cover letter) it is send-email that handles the
> utf-8, but I don't know why it is not working, as there is a test in
> t9001-send-email that tests it. I think it worked, I'll try to bisect
> if I found a working version.

In fact I've been checking some of my cover letter and almost none of them have the MIME headers. One that have the MIME headers is:

Subject: [PATCHv4 0/4] Show author and/or committer in some cases
Date: Sun,  4 May 2008 18:04:48 +0200
Message-Id: <1209917092-12146-1-git-send-email-sbejar@gmail.com>
X-Mailer: git-send-email 1.5.5.1.224.gadb29
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

But I don't know/remeber what I did differently and I cannot reproduce it even using the same git-send-email version.

So I don't know what else to look, and in fact I don't know who is responsible (if any) for these MIME headers in a cover-letter. But they are added automatically if you use the --compose flag. So maybe git-send-email could be enhanced so that it adds the MIME headers to the cover-letter (0000-cover-letter.patch) as if run with --compose.

Santi