Re: [PATCH] revision walker: include a detached HEAD in --all

From: Santi Béjar <santi@agolina.net>
Date: Jan 16, 2009, 13:12 UTC
Message-ID: <adf1fd3d0901160512i2de8f473gd471cc1dcb72afa4@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0901161351460.3586@pacific.mpi-cbg.de>

2009/1/16 Johannes Schindelin <Johannes.Schindelin@gmx.de>:

Show 13 quoted lines

>
> When HEAD is detached, --all should list it, too, logically, as a
> detached HEAD is by definition a temporary, unnamed branch.
>
> It is especially necessary to list it when garbage collecting, as
> the detached HEAD would be trashed.
>
> Noticed by Thomas Rast.
>
> Note that this affects creating bundles with --all; I contend that it
> is a good change to add the HEAD, so that cloning from such a bundle
> will give you a current branch.  However, I had to fix t5701 as it
> assumed that --all does not imply HEAD.

>From the description I understand that it only affects when the HEAD

is detached, but in t5701 the HEAD is not detached so nothing should be fixed.

For gc for sure it is a good thing, but I'm not convinced of the others, as a detached HEAD is a very special thing (temporary and unnamed branch).

Santi