Re: gitweb html validation

From: Raphaël Gertz <mageia@rapsys.eu>
Date: Nov 16, 2016, 09:25 UTC
Message-ID: <add4ba7fced68430c421c6b0ec388a13@rapsys.eu>
In-Reply-To: <xmqqy40ks301.fsf@gitster.mtv.corp.google.com>

Le 16.11.2016 01:05, Junio C Hamano a écrit :

Show 14 quoted lines

> Ralf Thielow <ralf.thielow@gmail.com> writes:
> 
>> Only block level elements are
>> allowed to be inside form tags, according to
>> https://www.w3.org/2010/04/xhtml10-strict.html#elem_form
>> ...
>> I think it's better to just move the <form>-Tag outside of the
>> surrounding div?
>> Something like this perhaps, I didn't test it myself yet.
> 
> That sounds like a sensible update to me (no, I do not run gitweb
> myself).  Is this the only <form> we have in the UI, or is it the
> only one that is problematic?
>

There is an other form in the cgi line 4110 :
         print $cgi->start_form(-method => "get", -action => $action) .
               "<div class=\"search\">\n" .

But this one has a <div class="search"> inside.

The problem with projsearch I want to change is that the div is around the form without a container inside.

I agree with moving the <div class="projsearch"> inside the form if it's a better option.

Best regards