git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] Enable Rust by default

From
Patrick Steinhardt <ps@pks.im>
Date
Apr 8, 2026, 10:12 UTC
Message-ID
<adYqB0Ba65FEGHNB@pks.im>
In-Reply-To
<20260403011249.4133372-5-sandals@crustytoothpaste.net>
On Fri, Apr 03, 2026 at 01:12:49AM +0000, brian m. carlson wrote:
Show 11 quoted lines
> diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
> index 28cfe730ee..bf1fdbe968 100755
> --- a/ci/run-build-and-tests.sh
> +++ b/ci/run-build-and-tests.sh
> @@ -10,7 +10,6 @@ export TEST_CONTRIB_TOO=yes
>  case "$jobname" in
>  fedora-breaking-changes-musl|linux-breaking-changes)
>  	export WITH_BREAKING_CHANGES=YesPlease
> -	export WITH_RUST=YesPlease
>  	MESONFLAGS="$MESONFLAGS -Dbreaking_changes=true"
>  	MESONFLAGS="$MESONFLAGS -Drust=enabled"
I guess we can drop this flag, as well.
Show 8 quoted lines
> @@ -30,6 +29,7 @@ linux-TEST-vars)
>  	export GIT_TEST_PACK_USE_BITMAP_BOUNDARY_TRAVERSAL=1
>  	;;
>  linux-clang)
> +	export NO_RUST=UnfortunatelyYes
>  	export GIT_TEST_DEFAULT_HASH=sha1
>  	;;
>  linux-sha256)

Do we also want to to adjust one of the Meson-based jobs to not run with Rust?

Show 8 quoted lines
> diff --git a/meson.build b/meson.build
> index 8309942d18..4e1a58ee01 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1746,7 +1746,7 @@ version_def_h = custom_target(
>  libgit_sources += version_def_h
>  
>  cargo = find_program('cargo', dirs: program_path, native: true, required: get_option('rust'))
We should probably move this line into "src/meson.build".
Show 5 quoted lines
> -rust_option = get_option('rust').disable_auto_if(not cargo.found())
> +rust_option = get_option('rust')
>  if rust_option.allowed()
>    subdir('src')
>    libgit_c_args += '-DWITH_RUST'
Patrick
Previous: brian m. carlsonNext: brian m. carlson
Message 3 of 9 in “Enable Rust by default”
  1. 0/4 Enable Rust by defaultbrian m. carlson, Apr 3, 2026
  2. 4/4 Enable Rust by defaultbrian m. carlson, Apr 3, 2026
  3. Patrick SteinhardtApr 8, 2026
  4. 2/4 ci: install cargo on Alpinebrian m. carlson, Apr 3, 2026
  5. Patrick SteinhardtApr 8, 2026
  6. 1/4 docs: update version with default Rust supportbrian m. carlson, Apr 3, 2026
  7. 3/4 Linux: link against libdlbrian m. carlson, Apr 3, 2026
  8. Patrick SteinhardtApr 8, 2026
  9. Junio C HamanoApr 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.