git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] p5326: create tag needed for shared tests

From
René Scharfe <l.s.r@web.de>
Date
Oct 2, 2021, 17:22 UTC
Message-ID
<ad6777d3-73d0-54d9-200b-88aad2d265b4@web.de>
p5326 fails with the following error:
   perf 8 - rev-list with tag negated via --not --all (objects):
   running:
   		git rev-list perf-tag --not --all --use-bitmap-index --objects >/dev/null
   fatal: ambiguous argument 'perf-tag': unknown revision or path not in the working tree.
   Use '--' to separate paths from revisions, like this:
   'git <command> [<revision>...] -- [<file>...]'
Reason: 540cdc11ad (pack-bitmap: avoid traversal of objects referenced
by uninteresting tag, 2021-03-22) added two tests and created a tag as a
prerequisite for them.  9387fbd646 (p5310: extract full and partial
bitmap tests, 2021-08-31) moved the two tests (and others) to
t/perf/lib-bitmap.sh, but not the code for creating the tag.  2d59597333
(p5326: perf tests for MIDX bitmaps, 2021-08-31) used this library, but
didn't create the tag.
Create the neccesary tag in p5326 using the code from p5310.
Signed-off-by: René Scharfe <l.s.r@web.de>
---
 t/perf/p5326-multi-pack-bitmaps.sh | 6 ++++++
 1 file changed, 6 insertions(+)
diff --git a/t/perf/p5326-multi-pack-bitmaps.sh b/t/perf/p5326-multi-pack-bitmaps.sh
index 5845109ac7..51b5636259 100755
--- a/t/perf/p5326-multi-pack-bitmaps.sh
+++ b/t/perf/p5326-multi-pack-bitmaps.sh
@@ -10,6 +10,12 @@ test_expect_success 'enable multi-pack index' '
 	git config core.multiPackIndex true
 '

+# we need to create the tag up front such that it is covered by the repack and
+# thus by generated bitmaps.
+test_expect_success 'create tags' '
+	git tag --message="tag pointing to HEAD" perf-tag HEAD
+'
+
 test_perf 'setup multi-pack index' '
 	git repack -ad &&
 	git multi-pack-index write --bitmap
--
2.33.0
Next: Taylor Blau
Message 1 of 2 in “p5326: create tag needed for shared tests”
  1. p5326: create tag needed for shared testsRené Scharfe, Oct 2, 2021
  2. Taylor BlauOct 3, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.